Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the credentials policy from 'same-origin' to 'include' #5373

Open
YuJianrong opened this issue May 24, 2019 · 0 comments
Open

Change the credentials policy from 'same-origin' to 'include' #5373

YuJianrong opened this issue May 24, 2019 · 0 comments

Comments

@YuJianrong
Copy link

Is your feature request related to a problem?

The problem is:
My API and Swagger UI are hosted in different domains, and credential is required for some api. I found the credential in cookie is not sent for CORS calls.
I have enabled the CORS on the api server, the crendential is stopped by client (Swagger-UI).

Describe the solution you'd like

Change the credential policy of the featch call from same-origin to include:

credentials: "same-origin",

Additional context

I'm not sure is there any reason to use same-origin instead of include in Swagger-UI. Consider this UI is used for tecnical cases, there should be no security risk. Is there any special reason to use same-origin option for the crendential?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant