-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used specPath
for isShownKey
and some cleanup to support
#6200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@geraldglynn This PR is breaking. I also tried updating to latest branch, still breaking. It also needs Cypress tests to confirm that the models display, expand, collapse. Thanks! |
geraldglynn
force-pushed
the
models-scroll-to
branch
from
July 29, 2020 00:00
3c32e08
to
989c4ed
Compare
tim-lai
reviewed
Jul 31, 2020
tim-lai
reviewed
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
isShownKey
in Models does not always reflect its position in Definition YAML.Currently the
isShownKey
base is still['models']
in some places e.g. inreadyToScroll()
This update keeps it consistent when used in
readyToScroll()
,isShown()
,show()
,requestResolvedSubtree()
, etc.–
['definitions']
for Swagger 2.0–
['components', 'schemas']
for OAS3When possible
Im.List
is used akaspecPath
; when anIm.List
is not possible the array versionfullPath
is used.Motivation and Context
– The
isShownKey
is used inshow()
which displays in the URL fragment hash– Currently there is an issue with toggling an individual Model
– Inconsistencies in how
isShownKey
is built has caused confusionHow Has This Been Tested?
– This has been manually tested on local development
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests