Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use oneOfType in spec prop validation #6400

Merged
merged 2 commits into from Sep 21, 2020
Merged

Use oneOfType in spec prop validation #6400

merged 2 commits into from Sep 21, 2020

Conversation

k4m4
Copy link
Contributor

@k4m4 k4m4 commented Sep 14, 2020

Description

  • Prop validation of the spec attribute was using PropTypes.oneOf instead of PropTypes.oneOfType.

Motivation and Context

How Has This Been Tested?

  • Following reproduction steps outlined in the original issue.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai self-assigned this Sep 18, 2020
@tim-lai tim-lai merged commit 52360a0 into swagger-api:master Sep 21, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Sep 21, 2020

@k4m4 PR merged! Thanks for the contribution!

@k4m4
Copy link
Contributor Author

k4m4 commented Sep 21, 2020

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop warning caused by spec react attribute
2 participants