string samples should also be json stringified in case of json related content type #6412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves issue: quotes missing in string example values
Description
When generating json SampleSchema it should be taken in consideration to stringify string schema samples correctly.
In order to do so i included the string type check in the conditional return branch for stringifing the sample schema, chained by or operator.
Changed test to check for unnecessarily stringify non-object values, because it used string type to complete the test, now it uses number.
Added test to check if string values are stringified.
Motivation and Context
Found this issue while creating new aspnet core webapi with swagger ui.
The sample controller excepts a string body on post route.
Making the sample request via swagger-ui results in json deserializer exception, because of missing quotes around the string value.
Fixes #6120
How Has This Been Tested?
Checked in browser.
npm run test
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests