Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added deeplinking as prop #6424

Merged
merged 6 commits into from Sep 22, 2020
Merged

Conversation

revaret
Copy link
Contributor

@revaret revaret commented Sep 21, 2020

Description

Motivation and Context

How Has This Been Tested?

  1. Clone the swagger-api/swagger-ui repo and made the changes in the code.
  2. Execute the flavors/swagger-ui-react/release/run.sh script.
  3. The compiled library files we need are in the flavors/swagger-ui-react/dist folder. Verify the timestamps match when you ran the run.sh script.
  4. Copy the files to another folder , ran a example with the generated code.
  5. Tested deeplinking by putting the appropriate link in the browser.
  6. Repo => https://github.com/revaret/swagger-ui-react

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@revaret
Copy link
Contributor Author

revaret commented Sep 21, 2020

@tim-lai

@tim-lai
Copy link
Contributor

tim-lai commented Sep 21, 2020

@revaret Thanks for the PR! Please fill out the PR template, especially the "How has this been tested" section. Thanks.

@revaret
Copy link
Contributor Author

revaret commented Sep 22, 2020

@tim-lai done , sharing the created repo in case you need to test it

https://github.com/revaret/swagger-ui-react

@tim-lai tim-lai merged commit 6b12f15 into swagger-api:master Sep 22, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Sep 22, 2020

@revaret PR merged! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants