Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5989 Warning: Unknown prop initialValue on <input> tag. #6506

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

chanmj96
Copy link
Contributor

@chanmj96 chanmj96 commented Oct 11, 2020

Description
Specify initialValue as a variable to prevent passing it with otherProps into Input tag

Motivation and Context
Fixes #5989

How Has This Been Tested?
Successfully built and observed no console warnings or errors on Authorize button click

Screenshots (if appropriate):
For testing, the Authorize button is located on the right-hand side of this page
Screen Shot 2020-10-11 at 1 43 30 PM

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit 1af8678 into swagger-api:master Oct 15, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Oct 15, 2020

@chanmj96 Merged! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Unknown prop initialValue on <input> tag. Remove this prop from the element.
2 participants