Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): response data flows off the screen #6764

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

mathis-m
Copy link
Contributor

@mathis-m mathis-m commented Dec 30, 2020

Description

Response data no longer wraps text and flows off the screen.
Fixed it by changing:

code {
      background-color: #dedede;
      padding: 4px 4px 2px;
      white-space: pre;
 }

To:

code {
      background-color: #dedede;
      padding: 4px 4px 2px;
      white-space: pre-wrap;
      word-break: break-all;
 }

Motivation and Context

Fixes #6749

How Has This Been Tested?

browser

Screenshots (if appropriate):

Before:
image
After:
image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@watery
Copy link

watery commented Dec 31, 2020

Can you test this with a single long word (no spaces)? I hit this issue with a JWT token that I can no longer copy from the UI.

@mathis-m
Copy link
Contributor Author

mathis-m commented Jan 1, 2021

Can you test this with a single long word (no spaces)? I hit this issue with a JWT token that I can no longer copy from the UI.

Would look like this:
image

@watery
Copy link

watery commented Jan 2, 2021

Can you test this with a single long word (no spaces)? I hit this issue with a JWT token that I can no longer copy from the UI.

Would look like this:
image

Very good. Thank you.

@tim-lai tim-lai merged commit 85a3ec9 into swagger-api:master Jan 4, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Jan 4, 2021

@mathis-m PR is now merged! Thanks for the contribution!

mathis-m added a commit to mathis-m/swagger-ui that referenced this pull request Jan 13, 2021
tim-lai pushed a commit that referenced this pull request Jan 14, 2021
* fix(style): code should should wrap line

this time in correct place

* revert(#6764): reverted wrongly placed css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response data no longer wraps text and flows off the screen.
3 participants