fix(webpack): assets should not be treaded as esModule #6861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
loading
/\.(png|jpg|jpeg|gif|svg)$/
relied on the default options ofurl-loader
.In one of the latest releases they swiched the esModule default from false to true.
https://github.com/webpack-contrib/url-loader/releases/tag/v3.0.0
So in case of importing a asset with above stated types, it will be treated as esModule. This is why loading an svg resulted in [object%20Module].
To fix this I have edited the baseRules set to treat
/\.(png|jpg|jpeg|gif|svg)$/
as no esModule.Motivation and Context
Fixes #6850
How Has This Been Tested?
browser
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests