Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): assets should not be treaded as esModule #6861

Merged

Conversation

mathis-m
Copy link
Contributor

Description

loading /\.(png|jpg|jpeg|gif|svg)$/ relied on the default options of url-loader.
In one of the latest releases they swiched the esModule default from false to true.
https://github.com/webpack-contrib/url-loader/releases/tag/v3.0.0

switch to ES modules by default (the option esModule is true by default)

So in case of importing a asset with above stated types, it will be treated as esModule. This is why loading an svg resulted in [object%20Module].
To fix this I have edited the baseRules set to treat /\.(png|jpg|jpeg|gif|svg)$/ as no esModule.

Motivation and Context

Fixes #6850

How Has This Been Tested?

browser

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit cdfb64f into swagger-api:master Jan 22, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Jan 22, 2021

@mathis-m Thanks for the fix! Fyi, I didn't mean to merge this dependency bump due to this config issue (fixed by this PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expanding operations triggers a failing network request to "GET /[object%20Module]"
2 participants