Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tryItOutEnabled configuration #6865

Merged

Conversation

kyle-apex
Copy link
Contributor

allow users to set tryItOutEnabled: true to display
the "Try it out" section by default

Motivation and Context

Addressed #2805

How Has This Been Tested?

Ran in browser by setting ?tryItOutEnabled=true
Added Cypress test.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

allow users to set tryItOutEnabled: true to display
the "Try it out" section by default
@mathis-m
Copy link
Contributor

Fixes #6528

Copy link
Contributor

@tim-lai tim-lai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyle-apex Thanks for the PR! Functionally looks good, but let's add a "negative" test, where ?tryItOutEnabled=false still renders properly and doesn't display an expanded view.

@kyle-apex
Copy link
Contributor Author

@tim-lai Thanks for the tip. As it turns out, setting tryItOutEnabled=false behaved as if it was true. I fixed the issue for this configuration; however, it's worth mentioning as a future to-do that the previously existing boolean parameter configurations (ex: displayRequestDuration, displayOperationId) would fail the ?parameter=false test.

@tim-lai
Copy link
Contributor

tim-lai commented Jan 25, 2021

@kyle-apex Thanks, good to know about other cases for future PR(s). I made a commit suggestion, to explicitly check for "true".

update tryItOutEnabled to take === "true" for the
query string value or === true if someone
implements query string type parsing in the query
@tim-lai tim-lai merged commit 265bdc0 into swagger-api:master Jan 26, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Jan 26, 2021

@kyle-apex PR merged! Thanks for the contribution!

@kyle-apex
Copy link
Contributor Author

@tim-lai Thanks for your help and patience on my first submission!

@OndraZizka
Copy link

OndraZizka commented Feb 3, 2021

Hi, when is this going to be released? And will it be controlled only in URL? Or can it be propagated from Spring config YAML?

@mathis-m
Copy link
Contributor

mathis-m commented Feb 3, 2021

@OndraZizka I think it can be configured via all available config options.

@jonatan-bengtsson
Copy link

Hi, I'm using the latest openapi-ui in a Spring project.
Could someone help me figure out how to enable this flag?
It doesn't seem to be a available flag via springdoc config in application.yaml (yet anyways).
Is there a way to still enable swagger-ui config flags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants