Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swagger-ui-react): src filename extension to transpile #6876

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Jan 28, 2021

Description

change the src path extension from .js to .jsx.

Motivation and Context

With swagger-ui@3.41.0, the build process to release swagger-ui-react failed during the transpile step:

+ cd ./flavors/swagger-ui-react/release
+ mkdir -p ../dist
+ cp ../../../dist/swagger-ui.js ../dist
+ cp ../../../dist/swagger-ui-es-bundle.js ../dist
+ cp ../../../dist/swagger-ui.css ../dist
+ node create-manifest.js
+ ../../../node_modules/.bin/cross-env BABEL_ENV=commonjs ../../../node_modules/.bin/babel --config-file ../../../babel.config.js ../index.js
babel:
  ../index.js does not exist
Build step 'Execute shell' marked build as failure

This is due to a filename change in commit 265bdc0, from index.js -> index.jsx, which was trying to fix to an eslint lint error, enforced during commit, by husky:

error  JSX not allowed in files with extension '.js'  react/jsx-filename-extension

How Has This Been Tested?

successfully locally run /releases/run.sh

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit e538e26 into swagger-api:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant