support pkce when using basic auth header

[hcldan]

Fixes #7037

I hope... it looks like it should but the setup I am using only seems to have minified swagger-ui code.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

• No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
• Dependency changes (any modification to dependencies in package.json)
• Bug fixes (non-breaking change which fixes an issue)
• Improvements (misc. changes to existing features)
• Features (non-breaking change which adds functionality)

My changes...

• are breaking changes to a public API (config options, System API, major UI change, etc).
• are breaking changes to a private API (Redux, component props, utility functions, etc.).
• are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
• are not breaking changes.

Documentation

• My changes do not require a change to the project documentation.
• My changes require a change to the project documentation.
• If yes to above: I have updated the documentation accordingly.

Automated tests

• My changes can not or do not need to be tested.
• My changes can and should be tested by unit and/or integration tests.
• If yes to above: I have added tests to cover my changes.
• If yes to above: I have taken care to cover edge cases in my tests.
• All new and existing tests passed.

[hcldan]

@mathis-m @tim-lai could one of you take a look at and possibly merge this?

[mathis-m]

As documentation states:
useBasicAuthenticationWithAccessCodeGrant does execute authorization_code AND usePkceWithAuthorizationCodeGrant does only apply to authorizatonCode flows it should be implemented this way. Have not confirmed functionality but logic wise it looks good.

[mathis-m]

@hcldan you should probably add a test here to verify the changed logic test/unit/core/plugins/auth/actions.js.

[hcldan]

@mathis-m I would be more comfortable doing that if there were already a test for pkce in there... I'm not sure what kind of mocking you guys are expecting, and I don't have a dev env for this project. I'm coming from swagger-ui-express and noticed that the auth flow was messed up.

[mathis-m]

@hcldan i can have a look and create pr to your branch.

[hcldan]

@mathis-m thank you very much!

[mathis-m]

@hcldan have added PR hcldan#1

[tim-lai]

@hcldan @mathis-m PR merged! Thanks guys on the collaboration!

[hcldan]

@tim-lai can you kick out a release?

[hcldan]

@mathis-m any chance of cutting a new release?

[mathis-m]

Tim has merged several pr yesterday, I guess there will be some release soon.

[tim-lai]

Yup, a new release is now availabe. 😺