Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sample-gen): xml attr with media-type example value #7045

Merged

Conversation

mathis-m
Copy link
Contributor

@mathis-m mathis-m commented Mar 8, 2021

Description

xml attr should rely on sample not only on example which is btw. included in sample of cause.

Motivation and Context

Fixes #6615

How Has This Been Tested?

new test

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

xml attr should rely on sample not only on example which is btw. included in sample of cause.

Signed-off-by: mathis-m <mathis.michel@outlook.de>
@mathis-m mathis-m changed the title fix(sample-gen): xml attr with example override fix(sample-gen): xml attr with media-type example Mar 8, 2021
@mathis-m mathis-m changed the title fix(sample-gen): xml attr with media-type example fix(sample-gen): xml attr with media-type example value Mar 8, 2021
Signed-off-by: mathis-m <mathis.michel@outlook.de>
@mathis-m
Copy link
Contributor Author

mathis-m commented Mar 8, 2021

Follow up to #6634

@tim-lai tim-lai merged commit 902241c into swagger-api:master Mar 10, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Mar 10, 2021

@mathis-m PR merged! Thanks for the followup!

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong attribute rendering, in an example of a XML response
2 participants