Show file upload for schema binary format

[neiser]

When the spec has format: binary as the schema for a request body, the UI should show a file upload as it already does for some specific content types. This enables support for basically any type of content, see also discussion in #5636.

Description

• Checks for "format: binary" and then takes that if in request-body.jsx
• Also fixes a little display bug actually showing the selected content type

Motivation and Context

Fixes #5636

How Has This Been Tested?

Tested locally with spec from #5636 (comment)

Screenshots (if appropriate):

File upload for application/zip:

Correct content type display (instead of hardcoded value):

Checklist

My PR contains...

• Bug fixes (non-breaking change which fixes an issue)
• Features (non-breaking change which adds functionality)

My changes...

• are not breaking changes.

Documentation

• My changes do not require a change to the project documentation.

Automated tests

• My changes can and should be tested by unit and/or integration tests.

Can you maybe add a little test case? I'm not really familiar with the code base. Feel free to add commits to that PR!

[tim-lai]

@neiser Thanks for the PR! I think this solution is acceptable. I think we should also include a check for format: base64 as well. In addition, this PR should include tests, where Cypress is probably the easiest to implement.

[neiser]

@tim-lai Thanks for your response. If we want to support format: base64 as well, shouldn't Swagger UI also convert the payload which is uploaded accordingly? Or is this already happening in some other part of the code base?

I'm quite unexperienced in Swagger UI code base, but I'll see if I can manage to also write tests for it. I can't promise any timeline, so feel free to add it yourself if you find time.

[tim-lai]

@neiser I believe SwaggerUI generally expects/handles files as format: base64. I think this was due to original implementation support of application/octet-stream. So adding format:base64 makes it an explicit check that SwaggerUI should already support. 🤞 😄

[neiser]

@tim-lai I've added format: base64 support. I can't promise if I'll find time to write a cypress test case.

[neiser]

@tim-lai I've just added a cypress test verifying an upload button is displayed for the various options (either certain content types or schema formats). I didn't quite get your comment on base64 handling and I've also not a good clue how to test this properly (again, I'm quite unexperienced with e2e frontend testing).

Feel free to "edit" this PR and make corrections before merging. From my point of view, it should be done now.

[tim-lai]

@neiser The Cypress tests captured what I was looking for... that the file upload button is displayed. Thanks for feature, test, and follow-up. PR is merged!