New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add modelcollapse to primitive models #7557
feat: add modelcollapse to primitive models #7557
Conversation
@twjasa can you have a look at the failing tests please? I'll review this initially tomorrow and when tests are green! Thanks for your work so far :) |
@twjasa looks like the test is failing because the
|
Hey @mathis-m thanks for the suggestion, will look into it in a few hours. |
I just commited new changes to the behavior of collapse in primitivemodel. Now all tests passed 😄 . Never worked with cypress, it's amazing what it can do. |
@twjasa nice thanks for your effort, I will have a look at this later today. |
Thanks! I will definitely see it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twjasa Thanks for the PR! In reviewing the proposed changes, I don't think that the existing unit tests should be removed. At a glance, it looks like you would just need to add a prop to expandDepth
to force the component to display as expanded, so that you can test for elements inside.
Hey @tim-lai thanks for the suggestion, you were right about Please take a look whenever you can. Thanks again. |
@twjasa PR merged! Thanks for the update and contribution! |
This seems to have caused #8008 |
Add collapse to primitive models
Description
Now
primitive-model
is wrapped inside aModelCollapse
component to let the user expand and collapse all the content of each primitive models such as (string, number, integer and boolean)Motivation and Context
This is a fix to the following issue number #7549
How Has This Been Tested?
Screenshots (if appropriate):
Screen.Recording.2021-10-14.at.6.04.23.PM.mov
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests