Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): avoid empty div when there are no externalDocs #7997

Merged
merged 4 commits into from May 12, 2022

Conversation

matyjas
Copy link
Contributor

@matyjas matyjas commented Apr 26, 2022

Relocate div for externalDocs into conditional checking for existence of externalDocs entry.

Description

  • Move div into the conditional
  • Ran prettier on the file

Motivation and Context

Fixes #7996

How Has This Been Tested?

Manually tested on macOS with and without externalDocs

Screenshots (if appropriate):

Screenshot 2022-04-26 at 12 57 02

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai
Copy link
Contributor

tim-lai commented May 2, 2022

@matyjas Thanks for the PR! Looks good to me, though could you add a Cypress test or two that compares and verifiies the two cases as noted in your screenshot?

@tim-lai
Copy link
Contributor

tim-lai commented May 2, 2022

related to PR #7559

src/core/components/operation-tag.jsx Outdated Show resolved Hide resolved
@tim-lai tim-lai changed the title bug(ui): avoid empty div when there are no externalDocs fix(ui): avoid empty div when there are no externalDocs May 12, 2022
@tim-lai tim-lai merged commit abeb168 into swagger-api:master May 12, 2022
@tim-lai
Copy link
Contributor

tim-lai commented May 12, 2022

@matyjas PR merged! Thanks for the fix!

@matyjas matyjas deleted the bug/tag-desc-squeezed branch May 13, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag Description awkwardly constrained when there is no externalDocs entry
2 participants