Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand model if depth <= defaultModelExpandDepth #8186

Conversation

twjasa
Copy link
Contributor

@twjasa twjasa commented Sep 20, 2022

Description

The prop expanded is now expanded if it's less or equal than defaultModelExpandDepth

Motivation and Context

An issue was open (#8008) indicating that the prop defaultModelExpandDepth did not had the correct behavior.

How Has This Been Tested?

Create a new test.yaml file inside ./dev-helpers/ and paste the yaml code that is in the issue link. (#7549)
In ./dev-helpers/index.html change url parameter of ui variable to: ./dev-helpers/test.yaml
run npm run dev in terminal
Open http://localhost:3200/
Check if depth level expand properly depending on defaultModelExpandDepth

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit 6c03465 into swagger-api:master Sep 21, 2022
@tim-lai
Copy link
Contributor

tim-lai commented Sep 21, 2022

@twjasa PR merged! Thank you for the contribution and fix! Also thanks for having updated tests ready to go. 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants