Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'available authorization' popup: only show oauth2 scopes relevant for current endpoint (issue #8219) #8229

Merged
merged 3 commits into from Oct 24, 2022

Conversation

kai-morich
Copy link
Contributor

Description

Endpoint specific filtering of oauth2 scopes for 'available authorization' popup

Motivation and Context

Issue #8219

How Has This Been Tested?

Screenshots (if appropriate):

Before:

GET /pets

image

After:

GET /pets
image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai
Copy link
Contributor

tim-lai commented Oct 17, 2022

@kai-morich Thanks for the PR! It looks very promising! I think it would be beneficial to add Cypress E2E tests to cover and replicate in CI all of the manual testing that you have done so far.

Separately, this PR seems like it might also obsolete the need for #7712, by hiding non-relevant fields? Not sure, but would like to get your thoughts.

@tim-lai tim-lai self-assigned this Oct 17, 2022
@kai-morich
Copy link
Contributor Author

i will look into automated tests, but I don't think it is related to #7712. The number of input boxes is not affected by my change, only the number of scopes listed below

@kai-morich
Copy link
Contributor Author

added unit tests for new functionality (oauth2 scope filtering) and for existing functionality (security filtering)

@tim-lai tim-lai merged commit 9457566 into swagger-api:master Oct 24, 2022
@tim-lai
Copy link
Contributor

tim-lai commented Oct 24, 2022

@kai-morich PR merged! Thanks for the fix and contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants