Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oas31): defaultModelExpandDepth not applied to oneOf/anyOf #9510

Conversation

jux61
Copy link
Contributor

@jux61 jux61 commented Jan 23, 2024

Description

Issue 9508
On openapi 3.1, defaultModelExpandDepth configuration is not applied to oneOf/anyOf schemas

Limitation

Depth level for oneOf/anyOf schemas is not exactly respected due to title level

for example with a depth of 2, got
image
instead of
image

Motivation and Context

How Has This Been Tested?

Add one e2e test to check oneOf/anyOf subschema are well expended

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@glowcloud
Copy link
Contributor

Thanks for adding this fix!

This PR was superseded by #9581. Your changes will be properly attributed.

@glowcloud glowcloud closed this Feb 13, 2024
char0n pushed a commit that referenced this pull request Feb 14, 2024
…x keywords (#9581)

Refs #9508
Supersedes #9510

Co-authored-by: Julien Bourges <julien.bourges@actility.com>
@jux61 jux61 deleted the bug/9508-openapi31-expand-depth-conf-not-applied-to-xxxof branch April 8, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants