-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(spec): ignore empty string for multi-value parameter #9511
fix(spec): ignore empty string for multi-value parameter #9511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Please take a look at my comments.
15c85f4
to
338e6e8
Compare
338e6e8
to
b2bb04a
Compare
Are you expecting something else from me? |
We are investigating this further, as there might be some other related issues. We will let you know if there are any other changes needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Modify function used to get parameter values in plugin spec selector to ignore empty string when parameter is an array
Motivation and Context
Proposal to fix issue #9266, #5176
How Has This Been Tested?
Extend unit test
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests