Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spec): ignore empty string for multi-value parameter #9511

Conversation

jux61
Copy link
Contributor

@jux61 jux61 commented Jan 23, 2024

Description

Modify function used to get parameter values in plugin spec selector to ignore empty string when parameter is an array

Motivation and Context

Proposal to fix issue #9266, #5176

How Has This Been Tested?

Extend unit test

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Please take a look at my comments.

@jux61 jux61 force-pushed the bug/ignore-empty-string-for-multi-value-query-parameters branch 2 times, most recently from 15c85f4 to 338e6e8 Compare February 13, 2024 16:22
@jux61 jux61 force-pushed the bug/ignore-empty-string-for-multi-value-query-parameters branch from 338e6e8 to b2bb04a Compare February 14, 2024 10:38
@jux61
Copy link
Contributor Author

jux61 commented Feb 14, 2024

Are you expecting something else from me?

@glowcloud
Copy link
Contributor

We are investigating this further, as there might be some other related issues. We will let you know if there are any other changes needed.

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glowcloud glowcloud merged commit 0ce0509 into swagger-api:master Feb 15, 2024
6 checks passed
@jux61 jux61 deleted the bug/ignore-empty-string-for-multi-value-query-parameters branch April 8, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants