Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(json-schema-2020-12): defaultModelExpandDepth not expanding schemas #9581

Merged
merged 4 commits into from
Feb 14, 2024
Merged

fix(json-schema-2020-12): defaultModelExpandDepth not expanding schemas #9581

merged 4 commits into from
Feb 14, 2024

Conversation

glowcloud
Copy link
Contributor

Refs #9508
Supersedes #9510

@glowcloud glowcloud self-assigned this Feb 13, 2024
@glowcloud glowcloud mentioned this pull request Feb 13, 2024
Closed
17 tasks
char0n
char0n requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please have a look at my CRCs

char0n
char0n approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job!

@char0n char0n merged commit 0aed3bc into master Feb 14, 2024
6 checks passed
@char0n char0n mentioned this pull request Feb 14, 2024
Closed
@char0n char0n deleted the issue-9508 branch February 14, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees

@glowcloud glowcloud

Labels
cat: plugins type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glowcloud @char0n