Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: associate HTML labels with inputs #9599

Merged
merged 3 commits into from
Feb 15, 2024
Merged

fix: associate HTML labels with inputs #9599

merged 3 commits into from
Feb 15, 2024

Conversation

glowcloud
Copy link
Contributor

Refs #8879
Supersedes #9279

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did you make sure that all IDs are unique in application some other components don't generate the same ones?

@glowcloud
Copy link
Contributor Author

glowcloud commented Feb 15, 2024

The ones that are not generated like auth_password should be unique, there are no duplicated ones in the code.
And the ones that use controlId should be generated with _requests, _parameters or _responses, so it seems to me like they will also be unique to the given path + method. This change was based on

const regionId = createHtmlReadyId(`${method}${path}_responses`)

@char0n
Copy link
Member

char0n commented Feb 15, 2024

The ones that are not generated like auth_password should be unique, there are no duplicated ones in the code. And the ones that use controlId should be generated with _requests, _parameters or _responses, so it seems to me like they will also be unique to the given path + method. This change was based on

const regionId = createHtmlReadyId(`${method}${path}_responses`)

Ok sounds good. Go for a merge!

@char0n char0n merged commit 16fef96 into master Feb 15, 2024
7 checks passed
@char0n char0n deleted the issue-8879 branch March 6, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants