Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oas3): merge schema with schema unresolved by swagger-client #9794

Merged
merged 4 commits into from Apr 10, 2024
Merged

fix(oas3): merge schema with schema unresolved by swagger-client #9794

merged 4 commits into from Apr 10, 2024

Conversation

glowcloud
Copy link
Contributor

Refs #9790

@glowcloud glowcloud requested a review from char0n April 9, 2024 12:24
@glowcloud glowcloud self-assigned this Apr 9, 2024
char0n
char0n approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is sound! Thanks for the bugfix. I'll follow up with the complete refactor of this component. I'ts the only component in the codebase that is using react-immutable-pure-component

@char0n char0n merged commit 3bea389 into master Apr 10, 2024
8 checks passed
@char0n char0n mentioned this pull request Apr 10, 2024
Closed
@char0n char0n deleted the issue-9790 branch April 19, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees

@glowcloud glowcloud

Labels
specification: 3.x type: regression version: 5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glowcloud @char0n