Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system): allow wrapping components both from presets and plugins #9919

Merged
merged 2 commits into from May 7, 2024

Conversation

char0n
Copy link
Member

@char0n char0n commented May 7, 2024

Refs #7232 (comment)
Refs #7304

Motivation and Context

The expected behavior described in this issue has always been intended. It shouldn't matter if whether the plugins have been registered via presets or passed by the plugins option. Having said that, this is just a bug in the original behavior, and the expected behavior (called chaining in this issue) should be the default one. Wrapping actions and selectors already works like that (ref #7304).

In #7236, the remediation was provided, but unfortunately it also contains hidden bug, where the original components objects is being mutated by the combined plugins because of this line:

 const dest = pluginOptions.pluginLoadType === "chain" ? toolbox.getComponents() : {}

Action: we're gonna revert 516e666 and replace it with non-configurable solution. We're going to fix the mutation bug introduced by the line above.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n char0n merged commit 877470b into master May 7, 2024
8 checks passed
@char0n char0n deleted the char0n/7232 branch May 13, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant