Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autocompletion for authorization secrets #9921

Open
glowcloud opened this issue May 7, 2024 · 1 comment · May be fixed by #9935
Open

Disable autocompletion for authorization secrets #9921

glowcloud opened this issue May 7, 2024 · 1 comment · May be fixed by #9935

Comments

@glowcloud
Copy link
Contributor

When inputting values for the API key and bearer token, there's a possibility of autocompletion, which can potentially reveal previously used secrets.
We want these values to remain visible to users as they type, while ensuring that they are not exposed through autocompletion, similar to how it happens when creating secrets in GitHub repositories. As such, we propose to implement a simple solution by setting autoComplete=off for these inputs:

<Input
id="api_key_value"
type="text"
onChange={ this.onChange }
autoFocus
/>

<Input
id="auth-bearer-value"
type="text"
aria-label="auth-bearer-value"
onChange={ this.onChange }
autoFocus
/>

Additional context or thoughts

This issue was raised with #9858

@klm-turing klm-turing linked a pull request May 13, 2024 that will close this issue
17 tasks
@klm-turing
Copy link

@glowcloud I give a try to this with your recommendation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants