Add quotes to Id in SQL requests #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on merging this, @swanandp ? If this is not an acceptable solution, please provide feedback. I would like to see the UUID incompatibility resolved and am happy to help. Thanks. |
swanandp
added a commit
that referenced
this pull request
Oct 4, 2013
…b.com:webdoc * 'master' of github.com:webdoc/acts_as_list: Add missing quote for id in sql request. Add quote for id in sql request (for when id is a uuid string for example). Conflicts: lib/acts_as_list/active_record/acts/list.rb
|
I merged it, but Travis cannot run the build on 1.8.7 because of ActiveSupport 4.x, need to iron that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use UUID as Id, we need to quote the Id in SQL requests.