Add quotes to Id in SQL requests #69

Merged
merged 2 commits into from Oct 4, 2013

Conversation

Projects
None yet
3 participants

If we use UUID as Id, we need to quote the Id in SQL requests.

Alric commented Oct 3, 2013

Any update on merging this, @swanandp ?

If this is not an acceptable solution, please provide feedback. I would like to see the UUID incompatibility resolved and am happy to help. Thanks.

swanandp added a commit that referenced this pull request Oct 4, 2013

Merge pull request #69, "Add quotes to Id in SQL requests" from githu…
…b.com:webdoc

* 'master' of github.com:webdoc/acts_as_list:
  Add missing quote for id in sql request.
  Add quote for id in sql request (for when id is a uuid string for example).

Conflicts:
	lib/acts_as_list/active_record/acts/list.rb

@swanandp swanandp merged commit 7be3ff9 into swanandp:master Oct 4, 2013

1 check failed

default The Travis build failed
Details
Owner

swanandp commented Oct 4, 2013

I merged it, but Travis cannot run the build on 1.8.7 because of ActiveSupport 4.x, need to iron that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment