Fix update_all deprecation warnings in Rails 4.0.0.beta1 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It says the tests fail on CI. They all pass locally for me. None of my changes were crazy. Not sure what the issue is. I am using this code in production without issue. |
|
I think it failed on 1.8.7 build, complaining about Syntax error: https://travis-ci.org/swanandp/acts_as_list/jobs/5096078 [It seems to be working for me too, I am going to merge it] |
|
Oh good call. Fixed that error in 1.8.7. Now the tests pass for me on both. |
|
I was thinking about removing 1.8.7 support, now that 2.0 is up and running. |
swanandp
added a commit
that referenced
this pull request
Feb 28, 2013
Fix update_all deprecation warnings in Rails 4.0.0.beta1
|
I figure no reason to remove support if it's not that much work. If it becomes annoying, then it's probably not a big deal since near end of life. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.