Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add symbols #69

Merged
merged 1 commit into from Jun 24, 2014
Merged

add symbols #69

merged 1 commit into from Jun 24, 2014

Conversation

edef1c
Copy link
Contributor

@edef1c edef1c commented Apr 25, 2014

Hi there! I'm implementing a toy programming language in JS, on top of mori's data structures. The only thing I was really missing was a symbol type. I'm not sure if it's reasonable to include this in mori itself — I'll gladly maintain my fork for my use-case if you think it's not.

@swannodette
Copy link
Owner

Please create a new pull request, thanks!

@edef1c
Copy link
Contributor Author

edef1c commented Apr 26, 2014

Here you go, rebased it [=

@edef1c
Copy link
Contributor Author

edef1c commented Apr 29, 2014

I'm somewhat puzzled as to why Travis is reporting failure, tests succeed locally even after a fresh clone and with a fresh npm cache.

@swannodette
Copy link
Owner

Can you rebase this pull request? Thanks!

@edef1c
Copy link
Contributor Author

edef1c commented Jun 6, 2014

This should do the trick [=

swannodette added a commit that referenced this pull request Jun 24, 2014
@swannodette swannodette merged commit 37ce0b7 into swannodette:master Jun 24, 2014
@edef1c edef1c deleted the symbols branch June 25, 2014 11:39
@edef1c
Copy link
Contributor Author

edef1c commented Jun 25, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants