Add migration to correct unicode issues that were resolved by #295 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably need to rework after #314 |
| @@ -0,0 +1,12 @@ | |||
| class FixInvalidUnicode < ActiveRecord::Migration | |||
| def up | |||
| Story.all.each do |story| | |||
There was a problem hiding this comment.
I tent to prefer find_each for this kind of situation. find_each fetches and instantiates records in batches, which improves performance for large collections.
|
I'm usually a bit hesitant adding data migrations like this, mainly because classes and fields tend to change over time. In this case though, I'm fine with this migration, since I predict that the class |
|
Fixed, squashed, rebased, merged :) |
swanson
pushed a commit
that referenced
this pull request
Apr 23, 2014
Add migration to correct unicode issues that were resolved by #295
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Koronen
Sanity check for me :)