Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional requirements for testing in arch linux. #138

Merged
merged 2 commits into from Jan 22, 2017
Merged

Add additional requirements for testing in arch linux. #138

merged 2 commits into from Jan 22, 2017

Conversation

LukaK
Copy link
Contributor

@LukaK LukaK commented Dec 15, 2016

Hello,
I have followed instructions in README/Local developement/Testing page for starting and got two failures when running test. Test in questions are test_pydist and test_keygen.

I'm using Arch linux 4.8.13-1 and as a substitute for libssl-dev I've installed openssl since there is no libssl-dev.

This pull request fixes things.

@swapagarwal
Copy link
Owner

Can any other arch user verify this?

@swapagarwal swapagarwal mentioned this pull request Jan 1, 2017
Closed
@icyphox
Copy link

icyphox commented Jan 1, 2017

Yeah, there's no libssl-dev in Arch. You'll need openssl.

@swapagarwal
Copy link
Owner

@icyphox Cool, could you also verify the packages added here?

@icyphox
Copy link

icyphox commented Jan 1, 2017

Okay I know what keyring and keyring.alt are for, but I really can't tell why you'll need them here. And jsonschema too seems redundant. @LukaK, could you explain?

@LukaK
Copy link
Contributor Author

LukaK commented Jan 5, 2017

Sorry for the late reply guys. I've tested repository on a fresh install of arch linux and tests pass. Tests also pass on my home system after fixing some python version problems (tnx for that :D).

So only thing is to install libffi and openssl instead of libffi-dev and libssl-dev. Would you like this to be included in the readme?

@swapagarwal
Copy link
Owner

@LukaK No problem!
Cool. You can update this PR with an additional section for Arch Linux under point number 2 here: https://github.com/swapagarwal/JARVIS-on-Messenger/blob/master/README.md#local-development--testing
Also, reset the requirements.txt file to original one. So you should see only changes in README.md here: https://github.com/swapagarwal/JARVIS-on-Messenger/pull/138/files

@LukaK
Copy link
Contributor Author

LukaK commented Jan 8, 2017

@swapagarwal Finished!

I've also added Fedora section to cover major distributions and package managers. Hope it is ok.

Luka Krapic and others added 2 commits January 8, 2017 13:29
@LukaK
Add Arch Linux and Redhat package requirements to section 2 of Local
b5dd0a4 
Developement/Testing.

Add Debian based Linux package requirement to section 2 of Local
Developement/Testing.
@swapagarwal
Update requirements.txt
0138afd
@swapagarwal swapagarwal merged commit 8dd682d into swapagarwal:master Jan 22, 2017
@swapagarwal
Copy link
Owner

Thanks @LukaK! 👍

@LukaK LukaK deleted the arch_requirements branch December 11, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Suggestion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukaK @swapagarwal @icyphox