Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anime rating #40

Closed
akarshHegde opened this issue May 15, 2016 · 7 comments
Closed

Anime rating #40

akarshHegde opened this issue May 15, 2016 · 7 comments

Comments

@akarshHegde
Copy link
Contributor

Hey, I was thinking of working on the Anime rating feature. There is this Api from hummingbird.me that seems to be reliable and easy to use.

Check the api structure:

API-v1

Let me know your thoughts

@ghost
Copy link

ghost commented May 15, 2016

I'm getting a 404 error in every query. :/

@swapagarwal
Copy link
Owner

@akarshHegde Nice find; looks great! Go ahead, I'll be waiting for your PR. Hit me up if you need any help. 😄
@shanmukhateja https://hummingbird.me/api/v1/search/anime?query=death+note

@akarshHegde
Copy link
Contributor Author

It seem to work for me. Could you suggest some titles which didn't work for you?
anime

@ghost
Copy link

ghost commented May 15, 2016

It's working. I was sending the query wrong :p (guilty guilty)

@akarshHegde
Copy link
Contributor Author

Hey @swapagarwal the PR is ready, but i am not sure how to write the test cases.(I didn't quite understand how tests work 😲 ) Any suggestions?

@swapagarwal
Copy link
Owner

You sure learn fast!

@akarshHegde
Copy link
Contributor Author

😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants