Currency Conversion is not working

[ftang1996]

typing "usd to eur" does not work and neither does hitting the menu option for this

Jarvis responds with
"I couldn't convert between those currencies.
Please ask me something else, like:

• HKD to USD
• USD to EUR rate
• how much is 100 USD to INR"

[ftang1996]

I would like to see if i can fix this issue if that's ok

[chrisdawww]

Currency conversion is currently broken because the api request to api.fixer.io is invalid. I looked into it and the free api access only gives 1,000 api requests per month.

Another possibility would be renewing the api key and keeping a database somewhere where we keep a daily result of a bunch of common currencies to request against. This way we could control the amount of requests per month so one user can't just kill a month's worth of requests.

[hugopellissari]

What's the status on this? I'd love to contribute to fix it

[chrisdawww]

@illichosky Take a crack at it! I just diagnosed the issue, I wasn't planning on fixing it 👍

[hugopellissari]

@ChristopherDaw Hey Chris! I'd love to take this issue. I'm super busy this week, but I'm planning to PR a fix by next week. Could you assign me to the issue?

[chrisdawww]

@illichosky I'm not in charge here and I didn't open the issue so I don't think I can assign you to it. When you're done you can always reference the issue from the PR.

[myungyunC]

If this is still an open issue (which it seems to be) @goldtomato and I will take it!

We just need to make sure basic conversions work correct? Showing conversion rates and actually converting values to the desired currency?

[abhikot]

I will work on this issue! I'll investigate the api.fixer.io problem that ChristopherDaw mentioned above and potentially re-work the code and test locally.

[myungyunC]

@abhikot Hi! Goldtomato and I have already started working on it, and I would prefer to not just give up our work, so if it's alright we will continue to work on it :) we will make a pull request soon.

[abhikot]

@myungyunC Hello! I've also began working on it. Perhaps we can both try to fix it and collaborate soon to most effectively fix the issue and have our pull request accepted.