Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Passenger #158

Closed
1 task done
itaisteinherz opened this issue Nov 10, 2018 · 4 comments
Closed
1 task done

Remove Passenger #158

itaisteinherz opened this issue Nov 10, 2018 · 4 comments

Comments

@itaisteinherz
Copy link
Contributor

  • I've checked that this isn't a duplicate issue.

The Passenger promotion has ended (since the livestream was on November 1st), and so it should be removed from the website.
I can open a PR if there are no objections.

@vikaspotluri123
Copy link
Contributor

Go ahead 😄

@itaisteinherz
Copy link
Contributor Author

@vikaspotluri123 According to #154 and #88, we shouldn't remove an entry which has expired.
I think we can either put the promotion in a new file (e.g. data-expired.json) as suggested in the issue, or add a tag expired to the entry in data.json (like the hacktoberfest tag, but for generally expired offers).

@vikaspotluri123
Copy link
Contributor

add a tag expired to the entry in data.json (like the hacktoberfest tag, but for generally expired offers).

This would be the initial implementation of #88, are you willing to work on it?

@itaisteinherz
Copy link
Contributor Author

Sure. I think I'll be able to create a PR in a few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants