Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests #79

Closed
aslafy-z opened this issue Oct 3, 2018 · 11 comments
Closed

Add automated tests #79

aslafy-z opened this issue Oct 3, 2018 · 11 comments
Assignees
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt ❔ question Further information is requested

Comments

@aslafy-z
Copy link
Collaborator

aslafy-z commented Oct 3, 2018

Issuehunt badges

Need to check that

  • code is linted
  • the site builds
  • data.json is well formated
  • data.json links are not dead

What else ?


IssueHunt Summary

vikaspotluri123 vikaspotluri123 has been rewarded.

Backers (Total: $20.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@aslafy-z aslafy-z changed the title Add some tests Add some automated tests Oct 3, 2018
@swapagarwal swapagarwal added the ❔ question Further information is requested label Oct 4, 2018
@swapagarwal
Copy link
Owner

I was thinking along those lines too!

@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Oct 4, 2018

I seen this,

2018-10-04-124736_174x47_scrot

Are you using it Codeship ? Should we use it or another one (TravisCI, CircleCI, another one) ?
Could you grant me a read access to it (or turn it public) ?

@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Oct 4, 2018

Some visual testing materials:

@swapagarwal
Copy link
Owner

Yes, I was using CodeShip to test that the links are not dead. Since now we have a visual testing requirement, we'll need to explore the various options available. 😃

@swapagarwal
Copy link
Owner

swapagarwal commented Oct 5, 2018

Copied from #82

We need to have a test framework (not needed but better), add a test case for each platform we want to test on and use a CI to trigger them. As seen there: https://www.browserstack.com/automate/node#testing-frameworks

@aslafy-z aslafy-z changed the title Add some automated tests Add automated tests Oct 10, 2018
@IssueHuntBot
Copy link

@swapagarwal has funded $20.00 to this issue. See it on IssueHunt

@swapagarwal
Copy link
Owner

@vikaspotluri123 See if you get time?

@swapagarwal
Copy link
Owner

Closed in #228

@vikaspotluri123
Copy link
Contributor

Did we want to add visual testing?

@swapagarwal
Copy link
Owner

It's probably over-engineering at this point. 😅
The most active time is October only, and the rest of the year is pretty much unhappening (as we saw last year!).

@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 28, 2019

@swapagarwal has rewarded $14.00 to @vikaspotluri123. See it on IssueHunt

  • 💰 Total deposit: $20.00
  • 🎉 Repository reward(20%): $4.00
  • 🔧 Service fee(10%): $2.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt ❔ question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants