Partial closure #849
Merged
Partial closure #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caffeinum
reviewed
Nov 8, 2018
caffeinum
reviewed
Nov 8, 2018
caffeinum
reviewed
Nov 8, 2018
caffeinum
reviewed
Nov 8, 2018
caffeinum
reviewed
Nov 8, 2018
caffeinum
reviewed
Nov 8, 2018
0xZick
force-pushed
the
partialClosure
branch
from
6f49d4e
to
6c8ac68
Compare
caffeinum
suggested changes
Nov 8, 2018
caffeinum
reviewed
Nov 8, 2018
shared/pages/Listing/Listing.js
Outdated
| { id: 2, context: `2. To list your tokens, please send us the link to your peoject, erc20 address, icon, name and ticker (short name) to team@swap.online;`, }, | ||
| { id: 3, context: `3. We as well will announce listing of your tokens on our social media, mutial PR will benefit both sides.`, }, | ||
| { id: 4, context: `Crypto Pink Sheets: ALL Coins Welcome To SWAP.Online!`}, | ||
| { id: 1, context: `1. We can list your token on swap.online ;` }, |
There was a problem hiding this comment.
там двойные ID и проект не запускается даже, тебя это не смущает ?
There was a problem hiding this comment.
почему на develop запускается?
There was a problem hiding this comment.
там много что запускается он его просто собирает, а ты попробуй по ходить по страницам, там надо хотя бы E2E написать которые будут просто открывать все станицы и модальные окна отловим кучу багов)
There was a problem hiding this comment.
это изменения не для этого пулл-реквеста, их нужно делать в отдельном
There was a problem hiding this comment.
нет я так не думаю, в целом да такой подход правильнее, но когда явно не верно сделано
There was a problem hiding this comment.
- в твоих старых коммитах невозможно найти проблему
- каждый такой "фикс" это потенциально новый баг, и проверять его нужно отдельно
- никто нигде не пишет, что нужно в один коммит пихать изменения, которые случайно заметил
- культура коммитов уж точно важнее, чем архитектура приложения
caffeinum
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the correct PR bonus tokens ✨
💔Thank you!