-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Default Values to Documentation Pages #32
Comments
Hand is starting to heal so I should be able to dedicate time into this issue. |
I think this is a possible solution: TK05@0211681 Which outputs this parameters table: Parameters
|
The only issue with this is that on some pages the parameters table becomes unbearable to view. I tried completing this issue earlier, but I couldn't get it to fit in the page, so I scrapped what I had done. Maybe we need to create another table of just Python Parameter Variable and Default Value instead? |
As it stands, As for the table, is this because some of the patterns can be quite long? An option could be to just create another table like "Parameter Patterns". Might also be helpful to include known valid patters. |
I'm not sure what you mean by your first paragraph. Can you elaborate? What do you mean by "url helpers"? It's mostly because the parameter patterns are very long for some endpoints. And then some of the default values might also be long. Adding another column doesn't flow well with GitHub.
This is something I think we would need to append as User Added Information so that it's clearly stated in the endpoints. I think this information will eventually be easier to add and display in the future documentation website that is still pending. Right now the best method of action of accessing parameters or information regarding a parameter is to click on the parameter and view the information in the paramater.md file, since that is all user defined information. (Example: SeasonType ) |
Basically any parameter that has
So if we moved those statically set "url helpers" (basically anything in parameter_variations with a comment attached) to a separate reference table, we could then more easily reference default values by just looking up As for the second part, I agree about having User Added Information. I've been thinking of some ideas on that for a few days. Maybe it's worth creating a separate issue to brainstorm on that one. The |
Maybe it'll make more sense just to see the refactor master...TK05:development/doc-default-values Update: af88963 - Added default values to endpoint doc template and generator Update 2: bc88f5a - Finalized changes w/ separate parameter patterns table. Example Endpoint Doc |
I am hesitant to switch I think a better solution would be to Now this is not a great solution, but it's a bandaid to make things work without having to rework the tools. I would say if we were to rework the mapping file, we might as well rework most of the tools and switch templating over to use Jinja or something else that's more reliable than using literal python triple quote string formatting. I just don't want to make a major change into that process now, and then down the line, make another major change while reworking the functionality of the tools. I also think it would be best to wait until after the summer when the next NBA season is going to start to make a major change to the functionality of all tools. Just so we don't get blindsided with changes over the summer or prior to the start of the next season. For As for as your example endpoint, I think this is going to be the best way of rendering default values inside those .md files. I like that a lot as it won't make the page extend too wide. And I think we should explictly flag |
I created a new issue for the On the default values I agree that it makes more sense to reference I think refactoring the tools to adjust for any new style of mapping shouldn't be too hard. I'd be willing to help get them working again if you go a different direction with the mapping design. The tools should support the project and not necessarily the other way around so a few hours of work would get everything back in order no problem. Switching to a template engine moving forward definitely makes sense and will help make any further additions to an endpoint documentation much easier. We can hold off on any big changes until the off season but maybe a new branch for WIP features to test and get the ball rolling if nothing major changes for next season might be wise. |
Per #31 (comment)
I want to add Default Values to the documentation page so users do not need to fumble in figuring out what values they need to pass.
No timeline when I can finish this task, currently with a hand injury in my dominant hand so will need to wait a bit for this to heal up before I can commit time to this issue.
The text was updated successfully, but these errors were encountered: