Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING file #56

Closed
eswan18 opened this issue Apr 11, 2019 · 1 comment · Fixed by #265
Closed

Add CONTRIBUTING file #56

eswan18 opened this issue Apr 11, 2019 · 1 comment · Fixed by #265
Labels
documentation Documentation is needed or requires an update

Comments

@eswan18
Copy link
Contributor

eswan18 commented Apr 11, 2019

More an idea than a need, but I think this repo is reaching a size that we should have some clearer instructions on how to raise issues and make pull requests, etc. I believe the standard for this is a CONTRIBUTING file. GitHub itself has some background here: https://help.github.com/en/articles/setting-guidelines-for-repository-contributors
@rsforbes rsforbes added the documentation Documentation is needed or requires an update label Sep 9, 2022
@rsforbes
Copy link
Collaborator

rsforbes commented Oct 1, 2022

#265

@rsforbes rsforbes linked a pull request Oct 1, 2022 that will close this issue
Updating Circle CI Build + CONTRIBUTING.md #265
Merged
@rsforbes rsforbes closed this as completed Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation is needed or requires an update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating Circle CI Build + CONTRIBUTING.md rsforbes/nba_api
2 participants
@rsforbes @eswan18