Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A toplevel notification system (for achievements, etc.) #916

Open
kostmo opened this issue Dec 14, 2022 · 5 comments
Open

A toplevel notification system (for achievements, etc.) #916

kostmo opened this issue Dec 14, 2022 · 5 comments
Labels
C-Project A larger project, more suitable for experienced contributors. S-Moderate The fix or feature would substantially improve user experience. Z-Feature A new feature to be added to the game. Z-User Experience This issue seeks to make the game more enjoyable to play.

Comments

@kostmo
Copy link
Member

kostmo commented Dec 14, 2022

Should have either a status bar or non-modal popup/dialog overlays (c.f. Toast on Android) to alert the user of certain events (e.g. attaining achievements (#797)).

This should not be the same as the "robot messages" window.

@kostmo kostmo added the Z-Feature A new feature to be added to the game. label Dec 14, 2022
@xsebek
Copy link
Member

xsebek commented Dec 14, 2022

As a note, one implementation that we discussed could be to add another layer to the entire game.

Currently, only the running game has two layers (dialogues and base layer) while the main menu only has one layer.

This way, achievements could popup even on the About page.

@kostmo kostmo added Z-User Experience This issue seeks to make the game more enjoyable to play. C-Project A larger project, more suitable for experienced contributors. S-Moderate The fix or feature would substantially improve user experience. labels May 29, 2023
@byorgey
Copy link
Member

byorgey commented Sep 10, 2023

Hmm, yes, adding another layer with non-modal popups could be a good, consistent way to add notifications across the entire game. A few more thoughts from #1506:

  • This would also work for notifications when new recipes or entities are unlocked.
  • We'd have to think about what should happen when multiple notifications are triggered at once (e.g. an achievement + new recipes unlocked). The simplest idea would probably be to just have a queue of notifications and display each for a certain amount of time.
  • Now that we have pretty-printing for Markdown we could make use of that for notification messages.
  • If we use pop-ups, I suppose putting them at or near the top of the window would probably be the least disruptive place.

@xsebek
Copy link
Member

xsebek commented Sep 11, 2023

If we use pop-ups, I suppose putting them at or near the top of the window would probably be the least disruptive place.

How about popup only for warning level greater or equal to user configured value? 🙂 (default error)

A UI at my work has it like that with buttons Clear and Hide.

We'd have to think about what should happen when multiple notifications are triggered at once.

If the popup is a scrollable list, then the preview could just show the categories: I 3 W 1 E 0 (or ℹ️ ⚠️ 🛑)

Alternatively I would be fine with a preview of the latest most serious notification, which would only be explicitly cleared by the player. Clearing notification could be as simple as right mouse click.

@byorgey
Copy link
Member

byorgey commented Sep 12, 2023

How about popup only for warning level greater or equal to user configured value? 🙂 (default error)

I was not thinking about popups in terms of errors at all, but rather for notifications of good things like unlocking achievements and recipes. After merging #1487, most errors and warnings can now be shown inline in the REPL. Were there additional sorts of "out-of-band" errors that you could imagine most effectively being shown via popups?

Also, for notifications of achievements, recipes, etc. I personally would rather have them just pop up for a certain (configurable) amount of time and then automatically disappear, rather than having to explicitly click to close them.

@xsebek
Copy link
Member

xsebek commented Sep 12, 2023

@byorgey I was thinking about system messages while you are playing the game. But maybe those could be filtered in message view.

I could imagine wanting to see some robot messages as a popup though. 🤔 I think we considered a dynamic system like that as an alternative to current objectives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Project A larger project, more suitable for experienced contributors. S-Moderate The fix or feature would substantially improve user experience. Z-Feature A new feature to be added to the game. Z-User Experience This issue seeks to make the game more enjoyable to play.
Projects
None yet
Development

No branches or pull requests

3 participants