Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

CI: YAML check #63

Open
fishnux opened this issue Aug 17, 2020 · 3 comments · Fixed by #71
Open

CI: YAML check #63

fishnux opened this issue Aug 17, 2020 · 3 comments · Fixed by #71
Labels
ci Continous Integration enhancement New feature or request

Comments

@fishnux
Copy link
Contributor

fishnux commented Aug 17, 2020

For every Git commit, YAML files must be checked to ensure proper validation.

Continuous integration software suggestions are welcome. I only used GitLab's CI.

@fishnux fishnux added enhancement New feature or request ci Continous Integration labels Aug 17, 2020
@woudsma woudsma added this to To do in Swarmlet v0.2 via automation Aug 17, 2020
This was referenced Sep 4, 2020
Swarmlet v0.2 automation moved this from To do to Done Sep 4, 2020
@woudsma
Copy link
Member

woudsma commented Sep 4, 2020

YAML files are now being validated in the deployer entrypoint script

python3 -c 'import yaml, sys; yaml.safe_load(sys.stdin)' <"$COMPOSE_FILE" &>/dev/null
[[ $? == "1" ]] && exit 1

@fishnux
Copy link
Contributor Author

fishnux commented Sep 4, 2020

I'm re-opening this issue because I'm referring to Continuous Integration checks, which aren't implemented yet. The deployer checks are still very useful! 😃

@fishnux fishnux reopened this Sep 4, 2020
Swarmlet v0.2 automation moved this from Done to In progress Sep 4, 2020
@fishnux fishnux moved this from In progress to To do in Swarmlet v0.2 Sep 4, 2020
@woudsma woudsma removed this from To do in Swarmlet v0.2 Oct 29, 2020
@woudsma woudsma added this to To do in Swarmlet v0.3 via automation Oct 29, 2020
@n-rodriguez
Copy link
Contributor

Continuous integration software suggestions are welcome. I only used GitLab's CI.

I can help you with that. I think GithubActions can do the job.

Just provide a Makefile with a task/target make lint-yaml.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continous Integration enhancement New feature or request
Projects
Swarmlet v0.3
  
To do
Development

Successfully merging a pull request may close this issue.

3 participants