Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot of work in main thread #3

Closed
Swati4star opened this issue Sep 30, 2016 · 11 comments
Closed

Lot of work in main thread #3

Swati4star opened this issue Sep 30, 2016 · 11 comments

Comments

@Swati4star
Copy link
Owner

The app is doing a lot of work in main thread.
Needs to be moved to Async task.

@ShivamArora
Copy link

I see this might have been already handled as the pdf is being created within an AsyncTask called creatingPdf which is executed in the createPdf() method.

Is there anything else to be done?

@Swati4star
Copy link
Owner Author

You can move this tasks to Async Tasks.
View Files

@mihudevcom
Copy link
Contributor

@Swati4star You need a loading dialog as well? Or just moving those to an AsyncTask will be enough? And why do you need an AsyncTask for this? I don't think it's loading that slow but maybe I'm missing something?

@Swati4star
Copy link
Owner Author

Just adding the tasks to AsyncTasks would be enough. Also, adding a dialog would be an enhancement.

The addition of this is just for worst case scenarios. It might take a significant amount of time in slower phones or if there is some exception. This is just for those cases.

@mihudevcom
Copy link
Contributor

@Swati4star Okay, sounds logical. Can I take care of this?

@Swati4star
Copy link
Owner Author

@mihudevcom Sure. Go ahead with this. If there is some issue, let me know. 👍

@mihudevcom
Copy link
Contributor

@Swati4star Any other issues for this case?

@Kartikdot
Copy link

Kartikdot commented Aug 21, 2017

I am new to open source. Can i go ahead with the issue?

@khokharnikunj8
Copy link

I think its time for closing this issue . .. @Swati4star @mihudevcom

@mihudevcom
Copy link
Contributor

@khokharnikunj8 Let's wait for @Swati4star and see what she says.

@Swati4star
Copy link
Owner Author

@khokharnikunj8 @mihudevcom Yes, I think I should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants