Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature : Add option to 'Show details' in PDF Actions #86

Closed
Swati4star opened this issue Jun 7, 2018 · 16 comments
Closed

New feature : Add option to 'Show details' in PDF Actions #86

Swati4star opened this issue Jun 7, 2018 · 16 comments

Comments

@Swati4star
Copy link
Owner

screenshot_20180607-154157

Add one more option in this dialog
'Show details'

On clicking this option, we will get another dialog with the following details about the selected PDF :

  1. Name
  2. Path
  3. Size
  4. Date Modified
  5. Date created

An example of this dialog :
screenshot_20180607-154352

@sholkay
Copy link
Contributor

sholkay commented Jun 14, 2018

I created a dialog which will show the following details about the selected PDF:

  • Name
  • Path
  • Size
  • Date Created
    But I am unable to understand and implement the Date Modified part.

@Swati4star
Copy link
Owner Author

You can leave the date modified part.

The other 4 fields are enough.

@Swati4star
Copy link
Owner Author

Also, try to make these fields copyable. so that the user can copy the file path.

@tanvidadu
Copy link

@Swati4star I think it would be helpful if we display some information like size, date of creation in the pdf converter list too. Would love to know your opinion!

@Swati4star
Copy link
Owner Author

@tanvidadu Yes. It does sound good. You can create a different issue for that.

@ac491
Copy link
Contributor

ac491 commented Jun 24, 2018

I would like to try to solve this issue

@Swati4star
Copy link
Owner Author

@sholkay Are you working on this issue?

( @ac491 , If he is not working on this issue, you can pick it up)

@sholkay
Copy link
Contributor

sholkay commented Jun 24, 2018

@ac491 Go ahead, I am working on something else right now.

@ac491
Copy link
Contributor

ac491 commented Jun 25, 2018

details_screen
@Swati4star, Is this alright?

@Swati4star
Copy link
Owner Author

looks good. Can you add on icon(copy icon) after the path, so that the user is able to click on the icon & copy path.

@ac491
Copy link
Contributor

ac491 commented Jun 25, 2018

I'll try it out.

The path is selectable though.

@Swati4star
Copy link
Owner Author

I hope it's not editable.
After selecting, can I copy it?

@ac491
Copy link
Contributor

ac491 commented Jun 25, 2018

yes, it's not editable and it can be copied.
copy

@Swati4star
Copy link
Owner Author

Swati4star commented Jun 25, 2018

Cool. You can leave the icon then.
There is a lot of difference between left margin of content & heading. Move the Details heading a bit to the left.

@ac491
Copy link
Contributor

ac491 commented Jun 25, 2018

screenshot_2018-06-25-12-17-35-768_swati4star createpdf

@Swati4star
Copy link
Owner Author

looks good. You can create a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants