Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.8 support #8

Closed
davidteal opened this issue Apr 8, 2019 · 6 comments
Closed

Laravel 5.8 support #8

davidteal opened this issue Apr 8, 2019 · 6 comments
Assignees

Comments

@davidteal
Copy link

Hi there.

Thanks for this library, it does exactly how I expected the default functionality to work. I'm having some issues with Laravel 5.8 though, as the cache TTL has changed from minutes to seconds.

See https://laravel.com/docs/5.8/releases#laravel-5.8 under PSR-16 Cache Compliance.

Are there any plans for an update?

Thanks.

@davidteal davidteal changed the title Laravel 5.8. support Laravel 5.8 support Apr 8, 2019
@swayok
Copy link
Owner

swayok commented Apr 8, 2019

Hi. I'm planning to deliver an update this week. I've just started a new project with Laravel 5.8 and probably will face this issue soon.

@swayok swayok self-assigned this Apr 8, 2019
@davidteal
Copy link
Author

Sorry to push but do you have any update? It's currently throwing the error below:

Declaration of AlternativeLaravelCache\Core\AlternativeTaggedCache::putMany(array $values, $minutes) should be compatible with Illuminate\Cache\TaggedCache::putMany

@swayok
Copy link
Owner

swayok commented Apr 16, 2019

@davidteal
This is just a coincidence but I've finished update for Laravel 5.8 several minutes ago =)
Also I've fixed that incompatibility in putMany you mentioned.
Unfortunately I cannot test it right now because I'm on a starting stage of my new project.

@davidteal
Copy link
Author

@swayok Great stuff. I'll update and will post here if I spot any issues.

Thanks.

@gmoigneu
Copy link

gmoigneu commented May 8, 2019

I can confirm this is working as expected on 5.8.16 Thanks!

@swayok
Copy link
Owner

swayok commented May 8, 2019

@gmoigneu Thank you for confirmation. Then I'm closing the issue.

@swayok swayok closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants