Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the presentation-time protocol #2950

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

emersion
Copy link
Member

No description provided.

@RyanDwyer
Copy link
Member

Is output_for_each_surface supposed to iterate all surfaces on the output or just the visible ones? Because if the workspace has a fullscreen container then it'll start with that as the root, and will run the callback for all tabbed children, even those which aren't visible. Sending frame done does this properly by calling view_is_visible in the iterator function, but send_presented_iterator does not.

@emersion
Copy link
Member Author

This is done in for_each_surface_container_iterator which is used for both. send_frame_done_iterator doesn't check view_is_visible.

@RyanDwyer
Copy link
Member

Oh, right.

@ddevault ddevault merged commit ea2497d into swaywm:master Oct 25, 2018
@ddevault
Copy link
Contributor

Thanks!

@emersion emersion deleted the presentation-time branch January 18, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants