Handle destroyed subsurfaces #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works fine. |
J0nnyMak0
approved these changes
Nov 27, 2018
RyanDwyer
reviewed
Nov 27, 2018
| if (child->view->container != NULL) { | ||
| view_child_damage(child, true); | ||
| } | ||
| view_child_destroy(child); |
There was a problem hiding this comment.
Doesn't this mean we call view_child_destroy twice now? view_child_init already sets up a listener on the surface's destroy event and calls it from the destroy handler.
There was a problem hiding this comment.
We have two objects: the wl_surface itself and the wl_subsurface. This listener is listening on the subsurface destroy event.
Destructors remove all listeners, so we should be fine if one is called before the other.
Damage subsurfaces when they are destroyed. Since subsurfaces don't have an unmap event we need to do that on destroy. We also don't want to keep a sway_view_child when the wlr_subsurface has been destroyed. Fixes swaywm#3197
emersion
force-pushed
the
handle-subsurface-destroy
branch
from
c2adeb9
to
fc79b7c
Compare
|
Works, thanks. |
RyanDwyer
approved these changes
Nov 28, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Damage subsurfaces when they are destroyed. Since subsurfaces don't have an
unmap event we need to do that on destroy.
We also don't want to keep a sway_view_child when the wlr_subsurface has been
destroyed.
Fixes #3197