-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swaylock: Fix caps lock not updating immediately #3367
Conversation
Partially fixes #2788. This change makes it so the lock screen is redrawn whenever the caps lock modifier state changes, rather on relying on the keypress event. This didn't work because caps lock is disabled when the key is released, not pressed, so the caps lock indicator does not go away until the next keypress event.
It looks like there are three things in that issue:
|
Thanks! |
Cool, another thank you from me! |
Implements customization for the indicator as proposed in swaywm#2788 with comments from swaywm#3367 in mind. The default behaviour does not change exept for the caps lock text color.
Implements customization for the indicator as proposed in swaywm#2788 with comments from swaywm#3367 in mind. The default behaviour does not change exept for the caps lock text color.
Implements customization for the indicator as proposed in swaywm#2788 with comments from swaywm#3367 in mind. The default behaviour does not change exept for the caps lock text color.
Partially fixes #2788. This change makes it so the lock screen is redrawn whenever the caps lock modifier state changes, rather on relying on the keypress event. This didn't work because caps lock is disabled when the key is released, not pressed, so the caps lock indicator does not go away until the next keypress event.
This doesn't fully implement the suggestions in #2788, but is a more basic fix that just makes it so the caps lock indicator is always accurate. I'd be happy to have a go implementng them if anyone's interested, although it doesn't personally seem to me that they'd be that useful.