Basic Zsh auto-completion for --options

[SethBarberee]

Hi, I've created at least a skeleton of zsh completion files for the sway, swaymsg, and swaygrab. Currently, it is only for --options but I will work on the other commands unless you say otherwise.
I'm sorry if it is a mess because it is my first time submitting a pull request to anything.

[mikkeloscar]

I think this is good, but maybe rename the files to something like completion.zsh or swaymsg-completion.zsh etc.

Also please use tabs for indentation, right now you use a mix of tabs and spaces :)

[SethBarberee]

I'll make sure to do that. The only thing that isn't in my request but should be is an update to cmake to install those files to the appropriate directory for zsh completions. I didn't do that because I did not how to code cmake.

On Jan 8, 2016, at 4:38 PM, Mikkel Oscar Lyderik notifications@github.com wrote:

I think this is good, but maybe rename the files to something like completion.zsh or swaymsg-completion.zsh etc.

Also please use tabs for indentation, right now you use a mix of tabs and spaces :)

—
Reply to this email directly or view it on GitHub.

[mikkeloscar]

It's pretty much done like this: https://github.com/SirCmpwn/sway/blob/master/CMakeLists.txt#L121

[SethBarberee]

Could this work for the cmake file? They will be placed with this cmake file in a directory called completions. However, the problem with suffixing them with .zsh screws up the autoloading feature because it has to be prefixed with an underscore such as _(command) for each completion file. If I am wrong, then please tell me!
https://gist.github.com/SethBarberee/7c833c963d06d1f4c778

[ddevault]

That should work. Make it optional, though.

[crondog]

Shouldn't the directory be share/zsh/site-functions as that is where third party completions go

[SethBarberee]

I debated this on the sway IRC was told that it was share/zsh/Completions/ but I do agree with you, crondog. I too think it should be share/zsh/site-functions.

Sent from my iPhone

On Jan 11, 2016, at 5:11 PM, crondog notifications@github.com wrote:

Shouldn't the directory be share/zsh/site-functions as that is where third party completions go

—
Reply to this email directly or view it on GitHub.

[mikkeloscar]

@SethBarberee share/zsh/site-functions is the correct path as mentioned by @crondog.

Could you also move the files to completions/zsh then it will be possible to add bash completions if anyone want that at some point.

Other than that it looks good.

[SethBarberee]

Will do :)

Sent from my iPhone

On Jan 11, 2016, at 5:19 PM, Mikkel Oscar Lyderik notifications@github.com wrote:

@SethBarberee share/zsh/site-functions is the correct path as mentioned by @crondog.

Could you also move the files to completions/zsh then it will be possible to add bash completions if anyone want that at some point.

Other than that it looks good.

—
Reply to this email directly or view it on GitHub.

[ddevault]

Can you squash all of this when you're done?

[SethBarberee]

I tried to squash them but to no avail... I'm sorry if i'm causing a lot of trouble. I'm still new to Git and I will try to fix the problems before I try to actually make the pull request. If I did somehow fix it then maybe there is hope..

[SethBarberee]

It says 9 days ago so I guess I squashed it? Idk

[ddevault]

Do this:

git rebase -i HEAD~18

Double check that you have all the right commits here, then replace "pick" with "squash" for all but the first commit, then save and close the file and enter a single commit message for this whole change. Then:

git push -f

[ddevault]

Whoops, you got one commit too many in the squash. This can't be merged like that. Can you just grab the relevant files and make a new commit on a new branch and open a new pull request?

[SethBarberee]

Yeah, I've been busy all week and forgot to do that. Thx!

Sent from my iPhone

On Jan 17, 2016, at 11:39 AM, Drew DeVault notifications@github.com wrote:

Whoops, you got one commit too many in the squash. This can't be merged like that. Can you just grab the relevant files and make a new commit on a new branch and open a new pull request?

—
Reply to this email directly or view it on GitHub.

[SethBarberee]

So I force-pushed this so now it's one commit. This should work now, I hope.

[ddevault]

Looks great. Nice work!