Fix inverted transforms #4996
Merged
Fix inverted transforms #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoeckl
reviewed
Feb 10, 2020
sway/commands/output/transform.c
Outdated
|
|
||
| // Sway uses clockwise transforms, while WL_OUTPUT_TRANSFORM_* describe | ||
| // anti-clockwise transforms | ||
| transform = wlr_output_transform_invert(transform); |
There was a problem hiding this comment.
While wlr_output_transform_invert correctly fixes the rotation direction for pure rotations, the inverse transformation of WL_OUTPUT_TRANSFORM_FLIPPED_90 is ..._FLIPPED_90, not the value ...._FLIPPED_270 that the wlroots patch changing rotation directions swapped it with.
There was a problem hiding this comment.
Oh, right. I guess the clockwise/anticlockwise handling needs to be fixed as well.
This wouldn't have any effect if the transform was flipped.
This patch makes it so users that have configured their screen with a transform don't have to update their config after the wlroots breaking change. References: swaywm/wlroots#2023
emersion
force-pushed
the
invert-transform
branch
from
ac09388
to
189a34f
Compare
|
Updated, also added a note in the docs. |
ddevault
approved these changes
Feb 17, 2020
|
Thanks! |
Xyene
added a commit
to Xyene/sway
that referenced
this pull request
May 28, 2020
After swaywm/wlroots#2023, swaywm#4996 inverted config inputs to `transform`. For consistency, we should also communicate inverted transformations via IPC. Closes swaywm#5356.
Xyene
added a commit
to Xyene/sway
that referenced
this pull request
May 28, 2020
After swaywm/wlroots#2023, swaywm#4996 inverted configuration transformations. For consistency, we should undo (double-apply) the inversion when communicating via IPC. Closes swaywm#5356.
Xyene
added a commit
to Xyene/sway
that referenced
this pull request
May 28, 2020
After swaywm/wlroots#2023, swaywm#4996 inverted configuration transformations. For consistency, we should undo (double-apply) the inversion when communicating via IPC. Closes swaywm#5356.
emersion
pushed a commit
that referenced
this pull request
May 28, 2020
After swaywm/wlroots#2023, #4996 inverted configuration transformations. For consistency, we should undo (double-apply) the inversion when communicating via IPC. Closes #5356.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it so users that have configured their screen with a
transform don't have to update their config after the wlroots breaking
change.
References: swaywm/wlroots#2023