Use new wlroots API for clearing keyboard/pointer focus during grabs #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not allowed to do what we did in swaywm#5222 and pass a `NULL` surface wlr_seat_pointer_notify_enter(), and it's causing crashes when an xdg-shell popup is active (see swaywm#5294 and swaywm/wlroots#2161). Instead, solve swaywm#5220 using the new wlroots API introduced in swaywm/wlroots#2217.
This was referenced May 21, 2020
|
I tested this in conjunction with the swaywm/wlroots#2217 and can confirm that this fixes the annoying crashes I observe when changing windows while a right-click menu is open. |
Closed
Xyene
added a commit
to Xyene/sway
that referenced
this pull request
Jun 19, 2020
Fixes swaywm#5469, a minor regression introduced in swaywm#5368.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not allowed to do what we did in #5222 and pass a
NULLsurface wlr_seat_pointer_notify_enter(), and it's causing crashes when an xdg-shell popup is active (see #5294 and swaywm/wlroots#2161).Instead, solve #5220 using the new wlroots API introduced in swaywm/wlroots#2217.