Firefox bookmark popup not positioned correctly.

[tmccombs]

When I open a bookmark menu popup in firefox (native wayland) that results in a popup that would be taller than my screen without scrolling, the resulting popup is postioned much higher than it should be, which if my browser is near the top of the screen often means it is off screen. I am not entirely sure this is a problem with sway and not firefox, however, this issue doesn't happen in wayland gnome or weston, and the following output with WAYLAND_DEBUG=1 seems suspicious:

[3346006.972]  -> xdg_wm_base@29.create_positioner(new id xdg_positioner@82)
[3346006.980]  -> xdg_positioner@82.set_size(472, 1080)
[3346006.988]  -> xdg_positioner@82.set_anchor_rect(58, 63, 72, 21)
[3346006.999]  -> xdg_positioner@82.set_offset(0, 0)
[3346007.006]  -> xdg_positioner@82.set_anchor(6)
[3346007.014]  -> xdg_positioner@82.set_gravity(8)
[3346007.021]  -> xdg_positioner@82.set_constraint_adjustment(61)
[3346007.029]  -> xdg_wm_base@29.get_xdg_surface(new id xdg_surface@83, wl_surface@71)
[3346007.053]  -> xdg_surface@83.get_popup(new id xdg_popup@84, xdg_surface@51, xdg_positioner@82)
[3346007.068]  -> xdg_positioner@82.destroy()
[3346007.074]  -> wl_surface@71.commit()

...
[3346015.835] xdg_popup@84.configure(58, -996, 472, 84)
[3346015.850]  -> wl_surface@71.set_buffer_scale(1)
[3346015.919] xdg_surface@83.configure(636)
[3346015.928]  -> xdg_surface@83.ack_configure(636)
...
[3346020.273]  -> xdg_surface@83.set_window_geometry(0, 0, 472, 84)

Notice that sway has positioned it -996 pixels above the anchor (which is off screen) with a height of only 84 pixels (which is both off-screen and if it were on screen would be unusable).

What I would expect is that it would position it on screen and resize it to the height of my screen.

[p4block]

Are you running Nightly? I had this bug months ago but then one day I didn't.

[tmccombs]

No. I'm on 1.5.1 of sway, 0.12.0 of wlroots.

[tmccombs]

hmm, I meant to file this in the sway project, not wlroots, athough I'm not actually sure where the problem is.

[kennylevinsen]

@tmccombs Please test sway and wlroots master to see if the problem persists.

If it does not, remember to also close https://bugzilla.mozilla.org/show_bug.cgi?id=1644968.

[FreeFull]

I can still reproduce this, using sway 1.5-4e02a598 (Feb 19 2021, branch 'master'). To reproduce this, the bookmarks menu needs to have enough bookmarks to make it taller than the screen.

[tmccombs]

I just tested on sway master (commit 4e02a59) and can still reproduce.

[PanAeon]

Can reproduce this with sway 1.5 and firefox 86.0.1.

[kennylevinsen]

Can reproduce this with sway 1.5 and firefox 86.0.1.

The issue is already known and confirmed to persist on much newer versions of sway and wlroots by tmccombs.

Please only use "reactions" for +1's, and keep messages to new information and discussion. We get enough notifications as is. :)