Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pango markup config #601

Merged
merged 5 commits into from
Apr 24, 2016
Merged

Pango markup config #601

merged 5 commits into from
Apr 24, 2016

Conversation

Hummer12007
Copy link
Contributor

This PR adds the ability to toggle parsing pango markup for plaintext statuslines.

@ddevault
Copy link
Contributor

Can you call the option "pango_markup"?

@@ -46,6 +46,7 @@ char *parse_font(const char *font) {
struct config *init_config() {
struct config *config = calloc(1, sizeof(struct config));
config->status_command = NULL;
config->plaintext_markup = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing how this works compared to i3, but as I understand this is not possible in i3, so maybe it should default to false so it behaves as expected by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default text rendering in i3 is with pango markup enabled.

@Hummer12007
Copy link
Contributor Author

Hummer12007 commented Apr 24, 2016

Config options must be somehow renamed, too, in order to make sense though.
(pango_markup <pango|none> doesn't)

@ddevault ddevault merged commit 7efa9ab into swaywm:master Apr 24, 2016
@Hummer12007 Hummer12007 deleted the pango_markup_config branch April 30, 2016 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants