Multiple potential memory leaks

[tobiolo]

Please fill out the following:

• Sway Version:

  • sway version 1.8 (built from git source tree check-out at tag 1.8/branch v1.8)

• Description:

  • I build sway with Address Sanitizer enabled (meson build/ -Db_sanitize=address)
  • I start sway and exit sway via swaynag.
  • Address Sanitizer reports multiple potential memory leaks for swaynag and sway. While most of them are caused by third-party libraries, there are some that are caused directly from sway. These are as follows:

Direct leaks

Direct leak of 560 byte(s) in 1 object(s) allocated from:
    #0 0x5645cdc8e881 in __interceptor_calloc (/usr/local/bin/sway+0x143881) (BuildId: caa0f499542597fbde9d536086ebe18875afa8ec)
    #1 0x5645cde1a35d in output_create /dvl/sway/build/../sway/tree/output.c:91:31
    #2 0x5645cdd004e0 in server_init /dvl/sway/build/../sway/server.c:248:26
    #3 0x5645cdcfcc5e in main /dvl/sway/build/../sway/main.c:380:7
    #4 0x7fbaa9d1628f  (/usr/lib/libc.so.6+0x2328f) (BuildId: 1e94beb079e278ac4f2c8bce1f53091548ea1584)

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x5645cdc8e529 in malloc (/usr/local/bin/sway+0x143529) (BuildId: caa0f499542597fbde9d536086ebe18875afa8ec)
    #1 0x5645cde29bb1 in create_list /dvl/sway/build/../common/list.c:8:17
    #2 0x5645cde0115c in root_create /dvl/sway/build/../sway/tree/root.c:41:30
    #3 0x5645cdcfcc1c in main /dvl/sway/build/../sway/main.c:378:9
    #4 0x7fbaa9d1628f  (/usr/lib/libc.so.6+0x2328f) (BuildId: 1e94beb079e278ac4f2c8bce1f53091548ea1584)

Indirect leaks

Indirect leak of 456 byte(s) in 1 object(s) allocated from:
    #0 0x5645cdc8e881 in __interceptor_calloc (/usr/local/bin/sway+0x143881) (BuildId: caa0f499542597fbde9d536086ebe18875afa8ec)
    #1 0x7fbaa9ffe3b4 in wlr_keyboard_group_create (/usr/lib/libwlroots.so.11+0x793b4) (BuildId: 82b60b3b4e82fd14b34e3b1e3e309097f02da882)
    #2 0x5645cdd47d13 in sway_keyboard_configure /dvl/sway/build/../sway/input/keyboard.c:1029:4
    #3 0x5645cdd56955 in seat_configure_keyboard /dvl/sway/build/../sway/input/seat.c:816:2
    #4 0x5645cdd56414 in seat_configure_device /dvl/sway/build/../sway/input/seat.c:902:4
    #5 0x5645cdd57376 in seat_add_device /dvl/sway/build/../sway/input/seat.c:970:2
    #6 0x5645cdd34ddc in input_manager_apply_seat_config /dvl/sway/build/../sway/input/input-manager.c:660:6
    #7 0x5645cdd34280 in input_manager_verify_fallback_seat /dvl/sway/build/../sway/input/input-manager.c:189:3
    #8 0x5645cdd35f8c in handle_new_input /dvl/sway/build/../sway/input/input-manager.c:244:2
    #9 0x7fbaaa090f6d in wl_signal_emit_mutable (/usr/lib/libwayland-server.so.0+0x9f6d) (BuildId: 1a07d2c4b6e9caafeaca9ee92ee77c983472874e)
    #10 0x7ffe050b149f  ([stack]+0x1f49f)

Indirect leak of 80 byte(s) in 1 object(s) allocated from:
    #0 0x5645cdc8e529 in malloc (/usr/local/bin/sway+0x143529) (BuildId: caa0f499542597fbde9d536086ebe18875afa8ec)
    #1 0x5645cde29cb3 in create_list /dvl/sway/build/../common/list.c:14:16
    #2 0x5645cde1a55f in output_create /dvl/sway/build/../sway/tree/output.c:103:31
    #3 0x5645cdd004e0 in server_init /dvl/sway/build/../sway/server.c:248:26
    #4 0x5645cdcfcc5e in main /dvl/sway/build/../sway/main.c:380:7
    #5 0x7fbaa9d1628f  (/usr/lib/libc.so.6+0x2328f) (BuildId: 1e94beb079e278ac4f2c8bce1f53091548ea1584)

Indirect leak of 80 byte(s) in 1 object(s) allocated from:
    #0 0x7ff1c16bfa89 in __interceptor_malloc /usr/src/debug/gcc/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x561d7faf8549 in create_list ../common/list.c:14
    #2 0x561d7faec360 in output_create ../sway/tree/output.c:102
    #3 0x561d7fa0e0a1 in server_init ../sway/server.c:248
    #4 0x561d7fa0bcff in main ../sway/main.c:380
    #5 0x7ff1c0d4628f  (/usr/lib/libc.so.6+0x2328f)

Indirect leak of 80 byte(s) in 1 object(s) allocated from:
    #0 0x5645cdc8e529 in malloc (/usr/local/bin/sway+0x143529) (BuildId: caa0f499542597fbde9d536086ebe18875afa8ec)
    #1 0x5645cde29cb3 in create_list /dvl/sway/build/../common/list.c:14:16
    #2 0x5645cde0115c in root_create /dvl/sway/build/../sway/tree/root.c:41:30
    #3 0x5645cdcfcc1c in main /dvl/sway/build/../sway/main.c:378:9
    #4 0x7fbaa9d1628f  (/usr/lib/libc.so.6+0x2328f) (BuildId: 1e94beb079e278ac4f2c8bce1f53091548ea1584)

Indirect leak of 80 byte(s) in 1 object(s) allocated from:
    #0 0x5645cdc8e529 in malloc (/usr/local/bin/sway+0x143529) (BuildId: caa0f499542597fbde9d536086ebe18875afa8ec)
    #1 0x5645cde29cb3 in create_list /dvl/sway/build/../common/list.c:14:16
    #2 0x5645cde1a523 in output_create /dvl/sway/build/../sway/tree/output.c:102:23
    #3 0x5645cdd004e0 in server_init /dvl/sway/build/../sway/server.c:248:26
    #4 0x5645cdcfcc5e in main /dvl/sway/build/../sway/main.c:380:7
    #5 0x7fbaa9d1628f  (/usr/lib/libc.so.6+0x2328f) (BuildId: 1e94beb079e278ac4f2c8bce1f53091548ea1584)

Indirect leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x5645cdc8e529 in malloc (/usr/local/bin/sway+0x143529) (BuildId: caa0f499542597fbde9d536086ebe18875afa8ec)
    #1 0x5645cde29bb1 in create_list /dvl/sway/build/../common/list.c:8:17
    #2 0x5645cde1a523 in output_create /dvl/sway/build/../sway/tree/output.c:102:23
    #3 0x5645cdd004e0 in server_init /dvl/sway/build/../sway/server.c:248:26
    #4 0x5645cdcfcc5e in main /dvl/sway/build/../sway/main.c:380:7
    #5 0x7fbaa9d1628f  (/usr/lib/libc.so.6+0x2328f) (BuildId: 1e94beb079e278ac4f2c8bce1f53091548ea1584)

Indirect leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x5645cdc8e529 in malloc (/usr/local/bin/sway+0x143529) (BuildId: caa0f499542597fbde9d536086ebe18875afa8ec)
    #1 0x5645cde29bb1 in create_list /dvl/sway/build/../common/list.c:8:17
    #2 0x5645cde1a523 in output_create /dvl/sway/build/../sway/tree/output.c:102:23
    #3 0x5645cdd004e0 in server_init /dvl/sway/build/../sway/server.c:248:26
    #4 0x5645cdcfcc5e in main /dvl/sway/build/../sway/main.c:380:7
    #5 0x7fbaa9d1628f  (/usr/lib/libc.so.6+0x2328f) (BuildId: 1e94beb079e278ac4f2c8bce1f53091548ea1584)

Are these leaks valid?